Re: [PATCH v3] mfd: core: Preserve OF node when ACPI handle is present
From: Andy Shevchenko
Date: Fri Mar 20 2026 - 03:28:03 EST
On Thu, Mar 19, 2026 at 06:12:31PM +0000, Lee Jones wrote:
> On Wed, 11 Mar 2026, Brian Mak wrote:
...
> > + if (adev)
> > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev));
> > + else
> > + set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(parent));
>
> Sorry to mess you around again, but how do you feel about:
>
> set_primary_fwnode(&pdev->dev, acpi_fwnode_handle(adev ?: parent));
If you think it's better, no objections from me.
Some maintainers prefer avoiding ternary, and specifically Elvis, some not —
hard to remember everybody's preferences :-)
--
With Best Regards,
Andy Shevchenko