RE: [PATCH net-next v3 11/13] dummy: convert to ndo_set_rx_mode_async

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Stanislav Fomichev <sdf@xxxxxxxxxxx>
> Sent: Friday, March 20, 2026 2:25 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; horms@xxxxxxxxxx; corbet@xxxxxxx;
> skhan@xxxxxxxxxxxxxxxxxxx; andrew+netdev@xxxxxxx;
> michael.chan@xxxxxxxxxxxx; pavan.chebbi@xxxxxxxxxxxx; Nguyen, Anthony
> L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; saeedm@xxxxxxxxxx; tariqt@xxxxxxxxxx;
> mbloch@xxxxxxxxxx; alexanderduyck@xxxxxx; kernel-team@xxxxxxxx;
> johannes@xxxxxxxxxxxxxxxx; sd@xxxxxxxxxxxxxxx; jianbol@xxxxxxxxxx;
> dtatulea@xxxxxxxxxx; sdf@xxxxxxxxxxx; mohsin.bashr@xxxxxxxxx; Keller,
> Jacob E <jacob.e.keller@xxxxxxxxx>; willemb@xxxxxxxxxx;
> skhawaja@xxxxxxxxxx; bestswngs@xxxxxxxxx; Loktionov, Aleksandr
> <aleksandr.loktionov@xxxxxxxxx>; kees@xxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-
> wireless@xxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx;
> leon@xxxxxxxxxx
> Subject: [PATCH net-next v3 11/13] dummy: convert to
> ndo_set_rx_mode_async
> 
> Convert dummy driver from ndo_set_rx_mode to ndo_set_rx_mode_async.
> The dummy driver's set_multicast_list is a no-op, so the conversion is
> straightforward: update the signature and the ops assignment.
> 
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
> ---
>  drivers/net/dummy.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index
> d6bdad4baadd..f8a4eb365c3d 100644
> --- a/drivers/net/dummy.c
> +++ b/drivers/net/dummy.c
> @@ -47,7 +47,9 @@
>  static int numdummies = 1;
> 
>  /* fake multicast ability */
> -static void set_multicast_list(struct net_device *dev)
> +static void set_multicast_list(struct net_device *dev,
> +			       struct netdev_hw_addr_list *uc,
> +			       struct netdev_hw_addr_list *mc)
>  {
>  }
> 
> @@ -87,7 +89,7 @@ static const struct net_device_ops dummy_netdev_ops
> = {
>  	.ndo_init		= dummy_dev_init,
>  	.ndo_start_xmit		= dummy_xmit,
>  	.ndo_validate_addr	= eth_validate_addr,
> -	.ndo_set_rx_mode	= set_multicast_list,
> +	.ndo_set_rx_mode_async	= set_multicast_list,
>  	.ndo_set_mac_address	= eth_mac_addr,
>  	.ndo_get_stats64	= dummy_get_stats64,
>  	.ndo_change_carrier	= dummy_change_carrier,
> --
> 2.53.0

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>