Re: [PATCH] HID: wiimote: Fix table layout in comment
From: David Rheinsberg
Date: Fri Mar 20 2026 - 04:49:30 EST
Hi
On Mon, Mar 16, 2026, at 3:45 PM, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@xxxxxxxxxx>
>
> Some tab characters snuck into the data layout table for turntable
> extensions, which resulted in the table only looking right at a tabstop
> of 4, which is uncommon in the kernel. Change them to the equivalent
> amount of spaces, which should look correct in any editor.
>
> Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx>
Reviewed-by: David Rheinsberg <david@xxxxxxxxxxxx>
This came in via 05086f3db530, which, looking at it, also left some trailing whitespace. Feel free to include those as well.
Thanks a lot!
> ---
> drivers/hid/hid-wiimote-modules.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-modules.c
> b/drivers/hid/hid-wiimote-modules.c
> index dbccdfa6391672..d9e1b4313d6465 100644
> --- a/drivers/hid/hid-wiimote-modules.c
> +++ b/drivers/hid/hid-wiimote-modules.c
> @@ -2442,12 +2442,12 @@ static void wiimod_turntable_in_ext(struct
> wiimote_data *wdata, const __u8 *ext)
> /*
> * Byte | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 |
> *------+------+-----+-----+-----+-----+------+------+--------+
> - * 0 | RTT<4:3> | SX <5:0> |
> - * 1 | RTT<2:1> | SY <5:0> |
> + * 0 | RTT<4:3> | SX <5:0> |
> + * 1 | RTT<2:1> | SY <5:0> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> * 2 |RTT<0>| ED<4:3> | CS<3:0> | RTT<5> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> - * 3 | ED<2:0> | LTT<4:0> |
> + * 3 | ED<2:0> | LTT<4:0> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> * 4 | 0 | 0 | LBR | B- | 0 | B+ | RBR | LTT<5> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> @@ -2458,12 +2458,12 @@ static void wiimod_turntable_in_ext(struct
> wiimote_data *wdata, const __u8 *ext)
> * With Motion+ enabled, it will look like this:
> * Byte | 8 | 7 | 6 | 5 | 4 | 3 | 2 | 1 |
> *------+------+-----+-----+-----+-----+------+------+--------+
> - * 1 | RTT<4:3> | SX <5:1> | 0 |
> - * 2 | RTT<2:1> | SY <5:1> | 0 |
> + * 1 | RTT<4:3> | SX <5:1> | 0 |
> + * 2 | RTT<2:1> | SY <5:1> | 0 |
> *------+------+-----+-----+-----+-----+------+------+--------+
> * 3 |RTT<0>| ED<4:3> | CS<3:0> | RTT<5> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> - * 4 | ED<2:0> | LTT<4:0> |
> + * 4 | ED<2:0> | LTT<4:0> |
> *------+------+-----+-----+-----+-----+------+------+--------+
> * 5 | 0 | 0 | LBR | B- | 0 | B+ | RBR | XXXX |
> *------+------+-----+-----+-----+-----+------+------+--------+
>
> ---
> base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c
> change-id: 20260316-wiimod-table-cd9abc0a2a98
>
> Best regards,
> --
> J. Neuschäfer <j.ne@xxxxxxxxxx>