Re: [PATCH v6 3/4] cpufreq: Set policy->min and max as real QoS constraints

[Viresh Kumar]

On 17-03-26, 11:17, Pierre Gondois wrote:
> cpufreq_set_policy() will ultimately override the policy min/max
> values written in the .init() callback through:
> cpufreq_policy_online()
> \-cpufreq_init_policy()
>   \-cpufreq_set_policy()
>     \-/* Set policy->min/max */
> Thus the policy min/max values provided are only temporary.

I am not comfortable with this patch to be honest. policy->min/max are used at
so many places that it is really difficult to make sure if this patch will break
something or not.

For example:

cpufreq_set_policy()
 cpufreq_driver->verify()
  cpufreq_frequency_table_verify()

This uses min/max before it is set by the path you mentioned.

I would suggest dropping this change, or most of it and doing only what is
really required for this series.

-- 
viresh