Re: [PATCH net-next v3 4/9] selftests: net: update some helpers to use run_on
From: Ioana Ciornei
Date: Fri Mar 20 2026 - 08:55:59 EST
On Fri, Mar 20, 2026 at 12:22:02PM +0100, Petr Machata wrote:
>
> Ioana Ciornei <ioana.ciornei@xxxxxxx> writes:
>
> > Update some helpers so that they are capable to run commands on
> > different targets than the local one. This patch makes the necesasy
> > modification for those helpers / sections of code which are needed for
> > the ethtool_rmon.sh test that will be converted in the next patches.
> >
> > For example, mac_addr_prepare() and mac_addr_restore() used when
> > STABLE_MAC_ADDRS=yes need to ensure stable MAC addresses on interfaces
> > located even in other namespaces. In order to do that, append the 'ip
> > link' commands with a 'run_on $dev' tag.
> >
> > The same run_on is necessary also when verifying if all the interfaces
> > listed in NETIFS are indeed available.
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>
>
> This looks good, but I'm unhappy with some overlong lines again :)
Sure, I will take care of them.