Re: [PATCH v3 1/3] dt-bindings: dma: arm-dma350: document generic and combined IRQ topologies
From: Krzysztof Kozlowski
Date: Fri Mar 20 2026 - 09:15:50 EST
On 20/03/2026 11:28, Jun Guo wrote:
>>> + description: |
>>> + The DMA controller may be configured with separate interrupts for each channel,
>>> + or with a single combined interrupt for all channels, depending on the SoC integration.
>>
>> And more important - you must review the LLM microslop output before
>> posting and adjust it to Linux kernel coding style. Don't send
>> unredacted tool output.
>>
> Actually, this part of the description was not AI-generated. However,
> I’d like to confirm the issue you mentioned: are you saying that this
> description is written too verbosely?
> Then, do you think there are still issues with the revised version?
> interrupts:
> minItems: 1
> maxItems: 8
> description:
> Either one interrupt per channel (8 interrupts), or one
> combined interrupt for all channels.
No, it is not wrapped according to Linux coding style.
Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool). However don't wrap blindly (see Kernel coding style).
Best regards,
Krzysztof