[PATCH] pinctrl: rtd: Fix error handling for devm_platform_ioremap_resource()
From: Felix Gu
Date: Fri Mar 20 2026 - 12:40:23 EST
devm_platform_ioremap_resource() returns ERR_PTR() on failure,
not NULL. The incorrect NULL check would fail to detect actual
errors from the ioremap operation.
Fix by using IS_ERR() and PTR_ERR() as documented for this API.
Fixes: b7f698b22b8b ("pinctrl: realtek: Switch to use devm functions")
Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
---
drivers/pinctrl/realtek/pinctrl-rtd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c
index 60dfb39bc986..429c94b79c49 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd.c
@@ -574,8 +574,8 @@ int rtd_pinctrl_probe(struct platform_device *pdev, const struct rtd_pinctrl_des
return -ENOMEM;
data->base = devm_platform_ioremap_resource(pdev, 0);
- if (!data->base)
- return -ENOMEM;
+ if (IS_ERR(data->base))
+ return PTR_ERR(data->base);
data->dev = &pdev->dev;
data->info = desc;
---
base-commit: b5d083a3ed1e2798396d5e491432e887da8d4a06
change-id: 20260321-rtd-ef9bf9f9cea7
Best regards,
--
Felix Gu <ustc.gu@xxxxxxxxx>