Re: [PATCH v11 02/65] dyndbg: factor ddebug_match_desc out from ddebug_change
From: Louis Chauvet
Date: Fri Mar 20 2026 - 12:42:01 EST
On Fri, 13 Mar 2026 07:19:27 -0600, Jim Cromie <jim.cromie@xxxxxxxxx> wrote:
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
> index 18a71a9108d3..6b1e983cfedc 100644
> --- a/lib/dynamic_debug.c
> +++ b/lib/dynamic_debug.c
> @@ -172,6 +172,52 @@ static struct ddebug_class_map *ddebug_find_valid_class(struct ddebug_table cons
> * callsites, normally the same as number of changes. If verbose,
> * logs the changes. Takes ddebug_lock.
> */
Can you add a bit of documentation about this function and move back the
above comment to the ddebug_change function?
With this: Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>
--
Louis Chauvet <louis.chauvet@xxxxxxxxxxx>