Re: [patch v2 07/11] futex: Add support for unlocking robust futexes

From: André Almeida

Date: Fri Mar 20 2026 - 13:21:34 EST


Em 19/03/2026 20:24, Thomas Gleixner escreveu:

The sys_futex() case [ab]uses the @uaddr2 argument to hand the pointer to
the kernel. This argument is only evaluated when the FUTEX_ROBUST_UNLOCK
bit is set and is therefore backward compatible.

I didn't find anywhere in the commit message that says what this pointers points to, so I would add:

"@uaddr2 argument to hand the address of robust list pending op to the kernel"

and also explain why we can't use current->futex.robust_list->list_op_pending (if I understood it correctly why):

"Instead of using the list_op_pending address found at current->futex.robust_list, use the address explicitly set by the user in the syscall arguments to avoid racing with set_robust_list()"


Anyway, this is

Reviewed-by: André Almeida <andrealmeid@xxxxxxxxxx>