Re: [PATCH 4/6] ARM: dts: BCM5301X: EA9200: add wifi definitions

[Rosen Penev]

On Fri, Mar 20, 2026 at 2:34 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:
>
> On 3/20/26 10:29, Florian Fainelli wrote:
> > On 3/19/26 17:29, Rosen Penev wrote:
> >> On Wed, Mar 18, 2026 at 8:53 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> >>>
> >>> brcm,ccode-map and ieee80211-freq-limit are needed to be specified on
> >>> some of them for proper operation.
> >>>
> >>> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> >>> ---
> >>>   .../dts/broadcom/bcm4709-linksys-ea9200.dts   | 50 +++++++++++++++++++
> >>>   1 file changed, 50 insertions(+)
> >>>
> >>> diff --git a/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts b/
> >>> arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
> >>> index 617fb55bc52f..7b1363aa1144 100644
> >>> --- a/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
> >>> +++ b/arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts
> >>> @@ -93,6 +93,56 @@ led-3 {
> >>>          };
> >>>   };
> >>>
> >>> +&pcie_bridge0 {
> >>> +       pcie@0,0 {
> >>> +               device_type = "pci';
> >>> +               reg = <0x0000 0 0 0 0>;
> >>> +               bus-range = <0x01 0xff>;
> >>> +
> >>> +               #address-cells = <3>;
> >>> +               #size-cells = <2>;
> >>> +               ranges;
> >>> +
> >>> +               pcie@1,0 {
> >>> +                       device_type = "pci';
> >> There are typos here. "pci' vs "pci". Should I resend?
> >
> > Not necessary, fixed it up while applying, thanks!
>
> Meh, this was not even build tested, even fixing that gives me:
Was build tested on kernel 6.12: https://github.com/openwrt/openwrt/pull/22223
>
>   ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make CHECK_DTBS=y
> broadcom/bcm4709-linksys-ea9200.dtb
>    DTC [C] arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dtb
> Lexical error:
> arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts:107.19-22
> Unexpected 'pci'
> Error: arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts:107.19-22
> syntax error
> FATAL ERROR: Unable to parse input tree
>
> Please resubmit patches 4 and 6 since I dropped them as a result.
There are three "pci' mistakes that are copy/paste in this patch. I'll resubmit.
> --
> Florian