Re: [PATCH v3 04/12] scsi: ufs: core: Add support for TX Equalization

[Can Guo]

On 3/19/2026 8:42 PM, Peter Wang (王信友) wrote:
> On Thu, 2026-03-19 at 13:49 +0800, Can Guo wrote:
> > Sure, for the lanes too. But I will still keep FOM records as u16,
> > because we
> > need to initialize it to a default value other than 0x0 to 0xFF such
> > that we
> > can differentiate a real FOM value (unit 8, read from RX_FOM) from
> > the
> > default one.
> > 
> > Thanks,
> > Can Guo.
> > 
>
> Hi Can,
>
> It seems keeping UINT16 is only for dumping this line.
> if (fom == 0xFFFFFFFF)
> seq_printf(s, "%8s%s", "-", " ");
>
> if the default scan covers all supported preshoot and
> deemphasis values, should the FOM value always be set based
> on the actual hardware reading and thus bypass the initial
> value check for FOM?
> Furthermore, if use_txeq_presets is true, could you simply
> dump only 8 values and bypass the check if FOM is at its
> initial value?
I figured out a better way to handle this. Please check the next version.
Thank you Peter for advising and providing valuable inputs.

Thanks,
Can Guo.
> Thanks.
> Peter
>
>
> ************* MEDIATEK Confidentiality Notice
>   ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
>   
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!