Re: [PATCH net-next] selftests: net: add tests for PPP

[Simon Horman]

On Fri, Mar 20, 2026 at 03:17:54PM +0800, Qingfang Deng wrote:
> Add ping and iperf3 tests for ppp_async.c and pppoe.c.
> 
> Signed-off-by: Qingfang Deng <dqfext@xxxxxxxxx>
> ---
>  MAINTAINERS                                   |  1 +
>  tools/testing/selftests/Makefile              |  1 +
>  tools/testing/selftests/net/ppp/Makefile      | 15 +++++++
>  tools/testing/selftests/net/ppp/config        |  8 ++++
>  tools/testing/selftests/net/ppp/ppp_async.sh  | 37 +++++++++++++++++
>  tools/testing/selftests/net/ppp/ppp_common.sh | 40 +++++++++++++++++++

Shellcheck flags two issues in ppp_common.sh. As we are aiming
for new tests to be shellcheck-clean I'd appreciate it if you could
look into this.

My suggestion is that SC2148 can be addressed by adding #!/bin/bash
to the top of the file.

And SC2153 can be suppressed using # shellcheck disable=SC2153 

For reference
+  https://www.shellcheck.net/wiki/SC2148
+  https://www.shellcheck.net/wiki/SC2153

...

> diff --git a/tools/testing/selftests/net/ppp/Makefile b/tools/testing/selftests/net/ppp/Makefile
> new file mode 100644
> index 000000000000..d2cbd6099255
> --- /dev/null
> +++ b/tools/testing/selftests/net/ppp/Makefile
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +top_srcdir = ../../../../..
> +
> +TEST_PROGS := \
> +	ppp_async.sh \
> +	pppoe.sh

Please add a trailing " \" to the line above,
so it won't need to be modified if another item
is added after it on a new line.

> +# end of TEST_PROGS
> +
> +TEST_FILES := \
> +	ppp_common.sh \
> +	pppoe-server-options

Here too.

> +# end of TEST_FILES
> +
> +include ../../lib.mk

...