Re: [PATCH v2 7/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for RTL9607C support
From: Krzysztof Kozlowski
Date: Sat Mar 21 2026 - 05:58:30 EST
On 21/03/2026 07:06, Rustam Adilov wrote:
>>>
>>> Would changing the commit message to something similar in vein to [1] be better?
>>>
>>> [1] - https://lore.kernel.org/linux-i2c/20250927101931.71575-9-jelonek.jonas@xxxxxxxxx/
>>
>> It does not cover clocks and it does not answer whether devices have it
>> or not.
>>
>> Decide first whether devices have the clock or not. I asked more than
>> once last time.
>
> I took some time to read the available docs like [1], [2] and my educated guess is, there has
> to be i2c clock/s and it is most likely connected to switch core by lexra bus as the other
> peripherals in SoC. I am not from Realtek so i don't know accurate that is.
> The difference with RTL9300/RTL9310 and RTL9607 is just, how SCL clock of the i2c master
> controller is configurable but that is for driver to deal with.
Then the clock should not be forbidden for the other variants and just
explain it in the commit msg.
Best regards,
Krzysztof