[PATCH] selftests/damon/sysfs.py: fixup: avoid unnecessary commit() and resume setup
From: SeongJae Park
Date: Sat Mar 21 2026 - 16:43:50 EST
As Sashiko suggested and I agreed.
Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
---
tools/testing/selftests/damon/sysfs.py | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 7a4cd915d5bc9..5f00e97f019f4 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -194,13 +194,16 @@ def assert_ctx_committed(ctx, dump):
def assert_ctxs_committed(kdamonds):
ctxs_paused_for_dump = []
+ kdamonds_paused_for_dump = []
# pause for safe state dumping
for kd in kdamonds.kdamonds:
for ctx in kd.contexts:
if ctx.pause is False:
ctx.pause = True
ctxs_paused_for_dump.append(ctx)
- if len(ctxs_paused_for_dump) > 0:
+ if not kd in kdamonds_paused_for_dump:
+ kdamonds_paused_for_dump.append(kd)
+ if kd in kdamonds_paused_for_dump:
err = kd.commit()
if err is not None:
print('pause fail (%s)' % err)
@@ -214,15 +217,14 @@ def assert_ctxs_committed(kdamonds):
exit(1)
# resume contexts paused for safe state dumping
- for kd in kdamonds.kdamonds:
- for ctx in ctxs_paused_for_dump:
- ctx.pause = False
- if len(ctxs_paused_for_dump) > 0:
- err = kd.commit()
- if err is not None:
- print('resume fail (%s)' % err)
- kdamonds.stop()
- exit(1)
+ for ctx in ctxs_paused_for_dump:
+ ctx.pause = False
+ if kd in kdamonds_paused_for_dump:
+ err = kd.commit()
+ if err is not None:
+ print('resume fail (%s)' % err)
+ kdamonds.stop()
+ exit(1)
# restore for comparison
for ctx in ctxs_paused_for_dump:
--
2.47.3