Re: [PATCH v5 6/7] gpio: dt-bindings: Add bindings for pinctrl based generic gpio driver

[Krzysztof Kozlowski]

On Sat, 21 Mar 2026 13:13:57 +0300, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Traditionally, firmware will provide a GPIO interface or a pin control
> interface.  However, the SCMI protocol provides a generic pin control
> interface and the GPIO support is built on top of that using the normal
> pin control interfaces.  Potentially other firmware will adopt a
> similar generic approach in the future.
> 
> Document how to configure the GPIO device.
> 
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Subject still did not improve. Drop driver.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
>
> diff --git a/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml b/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml
> new file mode 100644
> index 000000000000..9d20b5f23cdc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/pin-control-gpio.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/pin-control-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Pin control based generic GPIO controller
> +
> +description:
> +  The pin control-based GPIO will facilitate a pin controller's ability
> +  to drive electric lines high/low and other generic properties of a
> +  pin controller to perform general-purpose one-bit binary I/O.
> +
> +maintainers:
> +  - Dan Carpenter <dan.carpenter@xxxxxxxxx>

Typo, org.

Rest looks good, so with subject fix and above:


Best regards,
Krzysztof

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

-- 
Krzysztof Kozlowski <krzk@xxxxxxxxxx>