Re: [PATCH v6 03/12] iio: dac: ds4424: sort headers alphabetically

[Jonathan Cameron]

On Tue, 10 Feb 2026 14:51:01 +0100
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Sort the header inclusions alphabetically. This improves readability and
> simplifies adding new includes in the future.
> 
> Group subsystem-specific headers (linux/iio/*) separately at the end
> to clarify subsystem context.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

I applied this one by hand as iio/consumer.h isn't used and another
series had removed it in the meantime.

Thanks,

Jonathan

> ---
> changes v6:
> - no changes
> changes v5:
> - no changes
> changes v4:
> - no changes
> changes v3:
> - Keep linux/iio/* headers in a separate group at the end of the includes.
> changes v2:
> - new patch
> ---
>  drivers/iio/dac/ds4424.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 36286e4923af..c03051dc763e 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -6,16 +6,17 @@
>   */
>  
>  #include <linux/bits.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/i2c.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/i2c.h>
>  #include <linux/regulator/consumer.h>
> -#include <linux/err.h>
> -#include <linux/delay.h>
> -#include <linux/iio/iio.h>
> +
> +#include <linux/iio/consumer.h>
>  #include <linux/iio/driver.h>
> +#include <linux/iio/iio.h>
>  #include <linux/iio/machine.h>
> -#include <linux/iio/consumer.h>
>  
>  #define DS4422_MAX_DAC_CHANNELS		2
>  #define DS4424_MAX_DAC_CHANNELS		4