[PATCH v4 3/3] cxl/core: use cleanup.h for devm_cxl_add_dax_region

From: Gregory Price

Date: Sun Mar 22 2026 - 09:17:44 EST


Cleanup the gotos in the function. No functional change.

Signed-off-by: Gregory Price <gourry@xxxxxxxxxx>
---
drivers/cxl/core/region_dax.c | 13 +++++--------
drivers/cxl/cxl.h | 1 +
2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/cxl/core/region_dax.c b/drivers/cxl/core/region_dax.c
index fe367759ac69..de04f78f6ad8 100644
--- a/drivers/cxl/core/region_dax.c
+++ b/drivers/cxl/core/region_dax.c
@@ -81,29 +81,26 @@ static void cxlr_dax_unregister(void *_cxlr_dax)

int devm_cxl_add_dax_region(struct cxl_region *cxlr)
{
- struct cxl_dax_region *cxlr_dax;
struct device *dev;
int rc;

- cxlr_dax = cxl_dax_region_alloc(cxlr);
+ struct cxl_dax_region *cxlr_dax __free(put_cxl_dax_region) =
+ cxl_dax_region_alloc(cxlr);
if (IS_ERR(cxlr_dax))
return PTR_ERR(cxlr_dax);

dev = &cxlr_dax->dev;
rc = dev_set_name(dev, "dax_region%d", cxlr->id);
if (rc)
- goto err;
+ return rc;

rc = device_add(dev);
if (rc)
- goto err;
+ return rc;

dev_dbg(&cxlr->dev, "%s: register %s\n", dev_name(dev->parent),
dev_name(dev));

return devm_add_action_or_reset(&cxlr->dev, cxlr_dax_unregister,
- cxlr_dax);
-err:
- put_device(dev);
- return rc;
+ no_free_ptr(cxlr_dax));
}
diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
index f08be12e0e53..249a2f5ffc7b 100644
--- a/drivers/cxl/cxl.h
+++ b/drivers/cxl/cxl.h
@@ -712,6 +712,7 @@ DEFINE_FREE(put_cxl_root, struct cxl_root *, if (_T) put_device(&_T->port.dev))
DEFINE_FREE(put_cxl_port, struct cxl_port *, if (!IS_ERR_OR_NULL(_T)) put_device(&_T->dev))
DEFINE_FREE(put_cxl_root_decoder, struct cxl_root_decoder *, if (!IS_ERR_OR_NULL(_T)) put_device(&_T->cxlsd.cxld.dev))
DEFINE_FREE(put_cxl_region, struct cxl_region *, if (!IS_ERR_OR_NULL(_T)) put_device(&_T->dev))
+DEFINE_FREE(put_cxl_dax_region, struct cxl_dax_region *, if (!IS_ERR_OR_NULL(_T)) put_device(&_T->dev))

int devm_cxl_enumerate_ports(struct cxl_memdev *cxlmd);
void cxl_bus_rescan(void);
--
2.53.0