Re: [PATCH] lib/crc: arm64: add NEON accelerated CRC64-NVMe implementation
From: Eric Biggers
Date: Sun Mar 22 2026 - 10:13:39 EST
On Sun, Mar 22, 2026 at 11:29:36AM +0200, Demian Shulhan wrote:
> Hi Eric, David,
>
> Thanks to both of you for the review and suggestions! I've addressed
> all your comments and will send the v2 patch shortly.
>
> The idea of a unified PMULL template for ARM64 is very interesting. I
> can own it and work on it, but as it requires careful design (parallel
> folding across multiple vectors, handling LSB/MSB differences, and
> generalizing Barrett reduction), it will take some time to implement
> and test properly.
>
> Do you think it makes sense to merge this current solution(with fixed
> comments) for now, and I will follow up with the general template
> implementation in a separate patchset later?
>
> Thanks,
> Demian
That sounds good to me. Thanks!
- Eric