Re: [PATCH] ASoC: generic: update outdated comment for removed soc_bind_dai_link()

From: Kuninori Morimoto

Date: Sun Mar 22 2026 - 22:30:50 EST



Hi Kexin

> The function soc_bind_dai_link() was first merged into
> snd_soc_add_dai_link() by commit 63dc47da1f39 ("ASoC: soc-core: merge
> snd_soc_add_dai_link() and soc_bind_dai_link()"), and later renamed to
> snd_soc_add_pcm_runtime() by commit 0c04800424c4 ("ASoC: soc-core:
> rename snd_soc_add_dai_link() to snd_soc_add_pcm_runtime()").
>
> In simple-card.c, also adjust the wording since snd_soc_add_pcm_runtime()
> no longer uses "xxx_of_node" fields but matches components by of_node
> through snd_soc_find_dai() and snd_soc_is_matching_component().
>
> In simple-card-utils.c, simply update the function name to its
> successor snd_soc_add_pcm_runtime().
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> sound/soc/generic/simple-card.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
> index 06638f9a74b8..9937a991846e 100644
> --- a/sound/soc/generic/simple-card.c
> +++ b/sound/soc/generic/simple-card.c
> @@ -48,7 +48,8 @@ static int simple_parse_platform(struct simple_util_priv *priv,
>
> /*
> * Get node via "sound-dai = <&phandle port>"
> - * it will be used as xxx_of_node on soc_bind_dai_link()
> + * It will be used as the of_node for component matching during
> + * snd_soc_add_pcm_runtime().
> */
> ret = of_parse_phandle_with_args(node, DAI, CELL, 0, &args);
> if (ret)
> @@ -76,7 +77,8 @@ static int simple_parse_dai(struct simple_util_priv *priv,
>
> /*
> * Get node via "sound-dai = <&phandle port>"
> - * it will be used as xxx_of_node on soc_bind_dai_link()
> + * It will be used as the of_node for component matching during
> + * snd_soc_add_pcm_runtime().
> */
> ret = of_parse_phandle_with_args(node, DAI, CELL, 0, &args);
> if (ret)
> --
> 2.25.1
>