Re: Re: [PATCH v8 3/3] mmc: sdhci-esdhc-imx: remove redundant mx25 handling and consolidate soc data

[Fabio Estevam]

Hi Luke,

On Sun, Mar 22, 2026 at 11:38 PM Luke Wang <ziniu.wang_1@xxxxxxx> wrote:

> Hi Fabio,
>
> The option to remove the imx25-related code was actually suggested by me during the v4 patch discussion.
>
> "
> The original use of is_imx25_esdhc() to avoid setting DMA SELECT bits was because mx25 doesn't support ADMA, introduced in commit 9a0985b78d70.
>
> However, before that commit, imx25 was already using SDHCI_QUIRK_BROKEN_ADMA to disable ADMA (commit 97e4ba6a5ea9), which theoretically should prevent the DMA SELECT bits from being set.
>
> The actual reason DMA SELECT was being set incorrectly was due to a bug: u32 new_val was used without being initialized, causing DMA SELECT to potentially be set to random values.
>
> The new_val initialization issue was fixed in commit 81a0a8bc380d, but that fix was made for a different reason - it was not recognized at that time that the DMA SELECT issue was also caused by the uninitialized new_val. As a result, the is_imx25_esdhc() check was preserved.
>
> After the new_val initialization fix, is_imx25_esdhc() should no longer be necessary. So merging mx25 and mx35 is indeed valid. If you'd like, you can go further and remove the is_imx25_esdhc() related code entirely.
> "

Ok, thanks for the clarification.

This explanation should be part of the commit message.