Re: [PATCH v3 5/8] i2c: rtl9300: introduce clk struct for upcoming rtl9607 support

[Rustam Adilov]

On 2026-03-22 21:01, Krzysztof Kozlowski wrote:
> On 22/03/2026 13:34, Rustam Adilov wrote:
>>  DEFINE_GUARD(rtl9300_i2c, struct rtl9300_i2c *, mutex_lock(&_T->lock), mutex_unlock(&_T->lock))
>> @@ -432,6 +436,10 @@ static int rtl9300_i2c_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		return ret;
>>  
>> +	i2c->clk = devm_clk_get_optional_enabled(dev, NULL);
> 
> Undocumented ABI at this point.
> 
> Order your patches in correct order. First go bindings.

Will move the patch 7 to be before patch 5 in v4 of this patch series.

>> +	if (IS_ERR(i2c->clk))
>> +		return dev_err_probe(dev, PTR_ERR(i2c->clk), "Failed to enable i2c clock\n");
>> +
>>  	i = 0;
> Best regards,
> Krzysztof

Thanks,
Rustam