Re: [PATCH] dt-bindings: usb: qcom,snps-dwc3: Add missing clock constraints

From: Krzysztof Kozlowski

Date: Mon Mar 23 2026 - 04:38:31 EST


On 19/03/2026 10:23, Krzysztof Kozlowski wrote:
> The top-level part defines variable number of clocks and each "if:then:"
> block narrows them. It however narrows only the maxItems leaving
> minItems undefined, which then takes different values depending on
> dtschema being used.
>
> Recommended style is to avoid ambiguity in such case, thus if top-level
> part has broad constraints, then each "if:then:" must specify both upper
> and lower limits.
>
> Add missing constraints, mostly minItems but also maxItems for one
> variant.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> ---
>
> Apologies for sending two patches for the same file one after another as
> independent work. I do drive-by fixes when doing reviews and usually
> post such fix immediately.

I looked at Sashiko review of this patch and it nicely spotted more
issues in the original code (not my patch), so I will have more patches.
I will organize all of them into one patchset, so there will be v2 of this.

Best regards,
Krzysztof