Re: [PATCH 1/3] media: i2c: ov13b10: Add dvdd, dovdd and device tree support

[Sakari Ailus]

Hi Antoine,

On Sat, Mar 21, 2026 at 04:57:10AM +0000, Antoine Bernard wrote:
> Thanks for reviewing the patch.
> 
> This is my first time sending patches to LKML, so please do
> understand if I make some mistakes.
> --
> > Error handling needs some work here.
> 
> Could you perhaps tell me in detail? The logic is same as with
> avdd, so I am not quite sure how to refactor these.

What happens if enabling the last regulator fails?

> 
> > ACPI supports device probing through of_match_table, too.
> 
> I thought this was needed, because embedded devices don't have
> ACPI. Is it possible to not use of_match_ptr() and instead do
> .of_match_table = ov13b10_of_match directly?

Yes, please.

-- 
Regards,

Sakari Ailus