Re: [PATCH v5 7/7] gpio: gpio-by-pinctrl: add pinctrl based generic GPIO driver

[Andy Shevchenko]

On Sat, Mar 21, 2026 at 01:14:06PM +0300, Dan Carpenter wrote:

> The ARM SCMI pinctrl protocol allows GPIO access.  Instead of creating
> a new SCMI GPIO driver, this driver is a generic GPIO driver that uses
> standard pinctrl interfaces.

...

> +static int pin_control_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +				int val)
> +{
> +	unsigned long config;
> +
> +	config = PIN_CONF_PACKED(PIN_CONFIG_LEVEL, val);

No driver uses this macro directly.
pinconf_to_config_packed() is.

> +	return pinctrl_gpio_set_config(chip, offset, config);
> +}

-- 
With Best Regards,
Andy Shevchenko