Re: [PATCH RFC v2 3/9] iio: frequency: ad9910: add simple parallel port mode support

[Andy Shevchenko]

On Mon, Mar 23, 2026 at 10:39:06AM +0000, Rodrigo Alencar wrote:
> On 26/03/18 08:28PM, Andy Shevchenko wrote:
> > On Wed, Mar 18, 2026 at 05:56:03PM +0000, Rodrigo Alencar via B4 Relay wrote:
> > 
> > > Add parallel port channel with frequency scale, frequency offset, phase
> > > offset, and amplitude offset extended attributes for configuring the
> > > parallel data path.

...

> > > +	case IIO_CHAN_INFO_ENABLE:
> > > +		val = !!val;
> > 
> > Only used once, why do we need this...
> 
> Next patches introduce more channels here, so the additions are easier to review.

Yeah, but  shouldn't be better to put this in each FIELD_PREP() as it will
immediately show the correctness and the value range without looking backwards
in the code?

> > > +		switch (chan->channel) {
> > > +		case AD9910_CHANNEL_PARALLEL_PORT:
> > > +			tmp32 = FIELD_PREP(AD9910_CFR2_PARALLEL_DATA_PORT_EN_MSK, val);
> > 
> > ...and not just here?
> > 
> > > +			return ad9910_reg32_update(st, AD9910_REG_CFR2,
> > > +						   AD9910_CFR2_PARALLEL_DATA_PORT_EN_MSK,
> > > +						   tmp32, true);
> > > +		default:
> > > +			return -EINVAL;
> > > +		}
> 
> -- 
> Kind regards,
> 
> Rodrigo Alencar

-- 
With Best Regards,
Andy Shevchenko