Re: [PATCH 03/13] scsi: alua: Add scsi_alua_rtpg()

[John Garry]

On 18/03/2026 07:50, Hannes Reinecke wrote:
> > diff --git a/include/scsi/scsi_alua.h b/include/scsi/scsi_alua.h
> > index 07cdcb4f5b518..068277261ed9d 100644
> > --- a/include/scsi/scsi_alua.h
> > +++ b/include/scsi/scsi_alua.h
> > @@ -16,7 +16,15 @@
> >   struct alua_data {
> >       int            group_id;
> >       int            tpgs;
> > +    int            state;
> > +    int            pref;
> > +    int            valid_states;
> > +    bool            rtpg_ext_hdr_unsupp;
> > +    unsigned char        transition_tmo;
> > +    unsigned long        expiry;
> > +    unsigned long        interval;
> >       struct scsi_device    *sdev;
> > +    spinlock_t        lock;
> >   };
> >   int scsi_alua_sdev_init(struct scsi_device *sdev);
>
> Ah, right. Now I see where you want to go with the separate
> structure. Still wonder why you need the 'sdev' back link in
> there, though.

at some points we need to look up the sdev from alua data, like 
scsi_alua_rtpg_run()

> Other than that:
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

cheers