Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones

[Konrad Dybcio]

On 3/23/26 10:02 AM, Gaurav Kohli wrote:
> 
> 
> On 3/18/2026 3:14 PM, Konrad Dybcio wrote:
>> On 3/13/26 11:34 AM, Gaurav Kohli wrote:
>>> From: Manaf Meethalavalappu Pallikunhi <quic_manafm@xxxxxxxxxxx>
>>>
>>> The sm8750 includes four TSENS instances, with a total of 47 thermal
>>> sensors distributed across various locations on the SoC.
>>>
>>> The TSENS max/reset threshold is configured to 130°C in the hardware.
>>> Enable all TSENS instances, and define the thermal zones with a hot trip
>>> at 120°C and critical trip at 125°C.
>>>
>>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <quic_manafm@xxxxxxxxxxx>
>>> Signed-off-by: Gaurav Kohli <gaurav.kohli@xxxxxxxxxxxxxxxx>
>>> ---
>>
>> [...]
>>
>>> +        cpu-0-0-0-thermal {
>>> +            thermal-sensors = <&tsens0 1>;
>>> +
>>> +            trips {
>>> +                trip-point0 {
>>> +                    temperature = <120000>;
>>> +                    hysteresis = <5000>;
>>> +                    type = "hot";
>>> +                };
>>
>> Are we going to use these trip points for the CPUs? If not, let's only
>> keep the critical ones (again, for CPUs specifically since they get
>> externally throttled)
> 
> thanks Konrad, for review.
> We are not using this trip points for CPUs, For Kaanapali, Dmitry suggested to add more warning for CPUs also, if in case some user want to use it. So we have added for this soc also.

Alright, please resubmit with Krzysztof's comments addressed and retain
my r-b then

Konrad