Re: [RFC PATCH 1/2] thermal/cpufreq_cooling: remove unused cpu_idx in get_load()

From: Lukasz Luba

Date: Mon Mar 23 2026 - 09:38:06 EST




On 3/23/26 11:06, Viresh Kumar wrote:
On 23-03-26, 10:52, Lukasz Luba wrote:
How is that okay ? What am I missing ?

I was missing !SMP :)

Right, there is a mix of two things.
The 'i' left but should be removed as well, since
this is !SMP code with only 1 cpu and i=0.

The whole split which has been made for getting
the load or utilization from CPU(s) needs to be
cleaned. The compiled code looks different since
it knows there is non-SMP config used.

Right, we are allocating that for num_cpus (which should be 1 CPU
anyway). The entire thing must be cleaned.

Do you want to clean that or I should do this?

It would be helpful if you can do it :)


OK, I will. Thanks for your involvement Viresh!

Xuewen please wait with your v2, I will send
a redesign of this left code today.