Re: [PATCH v1 2/3] gpio: add support for Phytium platform GPIO controller

[Linus Walleij]

Hi Zhu,

thanks for your patch!

some quick remarks below:

On Mon, Mar 2, 2026 at 10:52 AM Zhu Ling <1536943441@xxxxxx> wrote:

> Add support for the Phytium platform GPIO controller with:
> - shared core helpers and irqchip implementation
> - platform probe path for OF/ACPI
> - Kconfig/Makefile integration
>
> The driver supports GPIO direction and value configuration, plus
> interrupt delivery for platform devices.
>
> Signed-off-by: Zhu Ling <1536943441@xxxxxx>

>  drivers/gpio/gpio-phytium-core.c     | 444 +++++++++++++++++++++++++++
>  drivers/gpio/gpio-phytium-core.h     |  90 ++++++
>  drivers/gpio/gpio-phytium-platform.c | 226 ++++++++++++++

Why this split? Put it all into one file.

Rewrite the driver to use the GPIO_GENERIC (MMIO) library,
select GPIO_GENERIC, look at other generic MMIO drivers
such as gpio-ftgpio010.c for inspiration.

Yours,
Linus Walleij