RE: [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into struct phy guts

[Alim Akhtar]

Hi Vladimir

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Sent: Monday, March 23, 2026 5:29 PM
> To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; Vinod Koul <vkoul@xxxxxxxxxx>; Neil
> Armstrong <neil.armstrong@xxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx;
> freedreno@xxxxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-arm-msm@xxxxxxxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; linux-
> riscv@xxxxxxxxxxxxxxxxxxx; linux-rockchip@xxxxxxxxxxxxxxxxxxx;
linux-samsung-
> soc@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx;
linux-sunxi@xxxxxxxxxxxxxxx;
> linux-tegra@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; spacemit@xxxxxxxxxxxxxxx;
> UNGLinuxDriver@xxxxxxxxxxxxx; Bart Van Assche <bvanassche@xxxxxxx>;
> Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Peter Griffin
> <peter.griffin@xxxxxxxxxx>; James E.J. Bottomley
> <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; Krzysztof Kozlowski
> <krzk@xxxxxxxxxx>; Chanho Park <chanho61.park@xxxxxxxxxxx>
> Subject: Re: [PATCH v5 phy-next 09/27] scsi: ufs: exynos: stop poking into
> struct phy guts
> 
> On Thu, Mar 19, 2026 at 10:15:17PM -0400, Martin K. Petersen wrote:
> > Vladimir,
> >
> > > The Exynos host controller driver is clearly a PHY consumer (gets
> > > the
> > > ufs->phy using devm_phy_get()), but pokes into the guts of struct
> > > ufs->phy
> > > to get the generic_phy->power_count.
> >
> > Ah, newer version. Would still like an ack from Samsung.
> >
> > And I hit the wrong key, I did not actually apply this...
> 
> I will have to resend v6 because of an armv7 build error I've caused for
ufs-
> qcom.c (which doesn't #include <linux/interrupt.h>, and relies on a
transitive
> inclusion from <linux/phy/phy.h>). It would be nice to get the ack from
> Samsung, but I'll send the next version in the upcoming hours regardless.
Will review and possibly test on one of the board later tonight