Re: [v3 1/3] mm/damon/sysfs: fix param_ctx leak on damon_sysfs_new_test_ctx() failure

From: Josh Law

Date: Mon Mar 23 2026 - 12:23:31 EST




On 23 March 2026 15:24:52 GMT, SeongJae Park <sj@xxxxxxxxxx> wrote:
>On Mon, 23 Mar 2026 09:25:52 +0100 Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
>> > Markus these patches are already merged
>
>It's still in mm-hotfixes-unstable. We can still make changes if needed.
>
>I understand what Markus is suggesting is adding another goto label to make
>the flow cleaner. Because this is a hotfix that aims to be also applied to
>stable kernels, I think the change is better to be as simple as possible.
>Adding another goto label could make it better, but I'm concerned if it will
>make porting difficult.
>
>IMHO, it is better to do that as a followup cleanup, rather than make change
>into the hotfix. Let me know if this change is somewhat critical and I'm
>missing that.
>
>>
>> Are there still development interests for the application of a better goto chain?
>
>Sure, if it makes it better, why not? :)
>
>
>Thanks,
>SJ
>
>[...]


Yeah, I understand where he's going with this, but I'll possibly make cleanup patches soon

V/R


Josh Law