Re: [PATCH 1/3] ASoC: jz4725b: Convert to devm_clk_get_enabled()
From: Mark Brown
Date: Mon Mar 23 2026 - 13:22:46 EST
On Mon, Mar 23, 2026 at 05:15:49PM +0100, Jihed Chaibi wrote:
> Use devm_clk_get_enabled() instead, which combines the get, prepare and
> enable operations into one call whose lifetime is tied to the device.
> This removes the need for explicit enable/disable in the component
> probe/remove callbacks, and ensures that clock enable failures are
> propagated as errors rather than silently ignored.
This will increase power consumption a little bit in the case where we
don't actually instantiate a sound card, the clocks will be turned on at
device probe time. How often these systems don't have a sound card, and
how noticable the additional power consumption from running the clocks
is, are separate questions - it might not be worth worrying about.
Attachment:
signature.asc
Description: PGP signature