Re: [PATCH v3 1/4] cpupower-idle-info.1: fix short option names

[Shuah Khan]

On 3/12/26 04:20, Roberto Ricci wrote:
> The cpupower-idle-info(1) man page describes '-f' as the short form of
> the '--silent' option and '-e' as the short form of the '--proc' option.
> But they are not correct:
>
> $ cpupower idle-info -f
> idle-info: invalid option -- 'f'
> invalid or unknown argument
> $ cpupower idle-info -e
> idle-info: invalid option -- 'e'
> invalid or unknown argument
>
> The short form of '--silent' is actually '-s' and the short form of
> '--proc' is actually 'o':
>
> cpuidle-info.c:
> 	{"silent", no_argument, NULL, 's'},
> 	{"proc", no_argument, NULL, 'o'},
>
> Fixes e7d85a934182d5bde1eea865169fbf2e0637a3ed ("cpupower: Add cpupower-idle-info manpage")

There is no need t for Fixes tag in any of these patches.
Fixes tag is used when you fix a bug in code. Using Fixes
for every single patch adds lot of churn for stable releases.

Remove Fixes tag from all these 4 patches and run checkpatch
before sending patches to me adding version information.

Incorrect fixes style in all of these 4 patches. Running checkpatch
helps you catch these error before I see them.

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e7d85a934182 ("cpupower: Add cpupower-idle-info manpage")'
#86:


> Signed-off-by: Roberto Ricci <io@xxxxxxxxxx>
> ---

Adding changes in since patch v1 makes reviewers job easier.
We can easily our comments are addressed or not.


>   tools/power/cpupower/man/cpupower-idle-info.1 | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/cpupower/man/cpupower-idle-info.1 b/tools/power/cpupower/man/cpupower-idle-info.1
> index 20b6345c53ad..b2f92aba5f5b 100644
> --- a/tools/power/cpupower/man/cpupower-idle-info.1
> +++ b/tools/power/cpupower/man/cpupower-idle-info.1
> @@ -11,10 +11,10 @@ A tool which prints out per cpu idle information helpful to developers and inter
>   .SH "OPTIONS"
>   .LP
>   .TP
> -\fB\-f\fR \fB\-\-silent\fR
> +\fB\-s\fR \fB\-\-silent\fR
>   Only print a summary of all available C-states in the system.
>   .TP
> -\fB\-e\fR \fB\-\-proc\fR
> +\fB\-o\fR \fB\-\-proc\fR
>   deprecated.
>   Prints out idle information in old /proc/acpi/processor/*/power format. This
>   interface has been removed from the kernel for quite some time, do not let

thanks,
-- Shuah