Re: [PATCH] ASoC: sun4i-spdif: Make reset control non-optional and check for all errors

[Jernej Škrabec]

Dne ponedeljek, 23. marec 2026 ob 18:24:48 Srednjeevropski standardni čas je Chen-Yu Tsai napisal(a):
> From: Chen-Yu Tsai <wens@xxxxxxxx>
> 
> The logic around the reset control is weird. The driver already has
> quirks describing which compatible strings require a reset control, but
> the reset control is acquired using the "optional" API. Then any errors
> other than deferred probe are ignored.
> 
> Instead, switch to the non-optional variant. Also use the deassered
> variant to simplify the code. This also fixes a missing reset assert
> upon removal.
> 
> Last, clean up the error message printing with dev_err_probe().
> 
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>

Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>

Best regards,
Jernej