Re: [PATCH] staging: rtl8723bs: tidy logical continuations in xmit_linux.c

[Ethan Tidmore]

On Mon Mar 23, 2026 at 2:15 PM CDT, sajal90 wrote:
> ---
You must have a SOB here above this line with your real name. Also, you
must have a patch note.

...

> -	if (!rtw_mc2u_disable
> -		&& check_fwstate(pmlmepriv, WIFI_AP_STATE) == true
> -		&& (IP_MCAST_MAC(pkt->data)
> -			|| ICMPV6_MCAST_MAC(pkt->data)
> -			)
> -		&& padapter->registrypriv.wifi_spec == 0) {
> +	if (!rtw_mc2u_disable &&
> +		check_fwstate(pmlmepriv, WIFI_AP_STATE) == true &&
> +		(IP_MCAST_MAC(pkt->data) ||
> +		 ICMPV6_MCAST_MAC(pkt->data)) &&
> +		padapter->registrypriv.wifi_spec == 0) {
>  		if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME / 4)) {
>  			res = rtw_mlcst2unicst(padapter, pkt);
>  			if (res)

 You fixed the logical continuation problem but the alignment is still
 wrong. It should be something like:

	if (!rtw_mc2u_disable &&
	    check_fwstate(pmlmepriv, WIFI_AP_STATE) &&
	    (IP_MCAST_MAC(pkt->data) || 
	     ICMPV6_MCAST_MAC(pkt->data)) &&
	    !padapter->registrypriv.wifi_spec) {

As you can see I removed the "== true" and the "== 0". Since you're
editing the line it's best to remove other checkpatch.pl warnings.
Mention these are removed in your patch notes aswell.

Thanks,

ET