Re: [PATCH net-next] net: ethtool: pass genl_info to the ethnl parse_request operation
From: Jakub Kicinski
Date: Mon Mar 23 2026 - 23:00:23 EST
On Mon, 23 Mar 2026 10:58:32 +0100 Maxime Chevallier wrote:
> The .parse_request() ethnl operation extracts the relevant attributes
> from the netlink request to populate the private req_info.
>
> By passing genl_info as a parameter to this callback, we can use
> the GENL_REQ_ATTR_CHECK() macro to check for missing mandatory
> parameters.
>
> This macro has the advantage of returning a better error explanation
> through the netlink_ext_ack struct.
>
> Convert the eeprom ethnl code to this macro, as it's the only command
> yet that has mandatory request parameters.
Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Thanks1