[PATCH v7] staging: rtl8723bs: remove commented-out code

From: Aadarsh Mandal

Date: Tue Mar 24 2026 - 00:07:58 EST


Remove code that is not used anywhere in driver.

Signed-off-by: Aadarsh Mandal <aadarshmandal9354@xxxxxxxxx>
---
v6:
- No change.
v5:
- No change.
v4:
- Remove extra space insertion.
- Delete remaining commented-out code.
v3:
- Add the extra space that count as insertion.
- Remove unwanted addition.
v2:
- Restore braces for standalone code blocks {}.
- Delete reindented commented-out code and extra space.
v1:
- Reindented commented-out code;extra space remained.

drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 -----------------
1 file changed, 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 063a0737933e..96a0c8e304da 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter *padapter)
{
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);

- /* Tx aggregation setting */
-/* sdio_AggSettingTxUpdate(padapter); */
-
/* Rx aggregation setting */
HalRxAggr8723BSdio(padapter);

@@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
return _SUCCESS;
}

- /* Disable Interrupt first. */
-/* rtw_hal_disable_interrupt(padapter); */
-
ret = _InitPowerOn_8723BS(padapter);
if (ret == _FAIL)
return _FAIL;
@@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)

rtl8723b_InitializeFirmwareVars(padapter);

-/* SIC_Init(padapter); */
-
if (pwrctrlpriv->reg_rfoff)
pwrctrlpriv->rf_pwrstate = rf_off;

@@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel,
CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_DONT_CARE);

- /* Record original value for template. This is arough data, we can only use the data */
- /* for power adjust. The value can not be adjustde according to different power!!! */
-/* pHalData->OriginalCckTxPwrIdx = pHalData->CurrentCckTxPwrIdx; */
-/* pHalData->OriginalOfdm24GTxPwrIdx = pHalData->CurrentOfdm24GTxPwrIdx; */
-
rtl8723b_InitAntenna_Selection(padapter);

/* */
@@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
/* ack for xmit mgmt frames. */
rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ_CTRL) | BIT(12));

-/* pHalData->PreRpwmVal = SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRPWM1) & 0x80; */
-
{
pwrctrlpriv->rf_pwrstate = rf_on;

@@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter)
pEEPROM->EepromOrEfuse = (eeValue & BOOT_FROM_EEPROM) ? true : false;
pEEPROM->bautoload_fail_flag = (eeValue & EEPROM_EN) ? false : true;

-/* pHalData->EEType = IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPROM_BOOT_EFUSE; */
-
_ReadEfuseInfo8723BS(padapter);
}

--
2.43.0