Re: [PATCH 5/5] pwm: tegra: Add support for Tegra264

From: Mikko Perttunen

Date: Tue Mar 24 2026 - 00:46:29 EST


On Monday, March 23, 2026 4:24 PM Krzysztof Kozlowski wrote:
> On 23/03/2026 03:36, Mikko Perttunen wrote:
> > +
> >
> > static const struct of_device_id tegra_pwm_of_match[] = {
> >
> > { .compatible = "nvidia,tegra20-pwm", .data = &tegra20_pwm_soc },
> > { .compatible = "nvidia,tegra186-pwm", .data = &tegra186_pwm_soc },
> > { .compatible = "nvidia,tegra194-pwm", .data = &tegra186_pwm_soc },
> >
> > + { .compatible = "nvidia,tegra264-pwm", .data = &tegra264_pwm_soc },
>
> Undocumented ABI.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
>
> Best regards,
> Krzysztof

So, this series was checkpatch --strict clean (modulo one false positive) when
I submitted. I agree that that is strange, so I looked into it and looks like
I had an old processed-schema.json file containing tegra264-pwm, so checkpatch
didn't complain. It is of course in .gitignore so I didn't notice.

Mikko