Re: [PATCH v2 2/2] mfd: rohm-bd718x7: Use software nodes for gpio-keys

From: Matti Vaittinen

Date: Tue Mar 24 2026 - 03:08:08 EST


On 23/03/2026 03:37, Dmitry Torokhov wrote:
Refactor the rohm-bd7182x7 MFD driver to use software nodes for
instantiating the gpio-keys child device, replacing the old
platform_data mechanism.

The power key's properties are now defined using software nodes and
property entries. The IRQ is passed as a resource attached to the
platform device.

This will allow dropping support for using platform data for configuring
gpio-keys in the future.

I think we miss Signed-off-by -line here. Other than that, similar comments as I had for the 1/2.


Yours,
-- Matti

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~