Re: [RFC PATCH 17/17] netfs: Combine prepare and issue ops and grab the buffers on request

From: David Howells

Date: Tue Mar 24 2026 - 03:33:22 EST


ChenXiaoSong <chenxiaosong@xxxxxxxxxxxxxxxx> wrote:

> In netfs_writeback_single(), on the failure path, should we call
> netfs_put_failed_request() instead of netfs_put_request()?

It doesn't matter exactly, as the only difference really is whether it gets
bumped over to a workqueue, but it's probably better to avoid that if we can.

David