Re: [PATCH -next] drm: verisilicon: make vs_dc_platform_driver static

[Thomas Zimmermann]

Am 24.03.26 um 07:08 schrieb Icenowy Zheng:
> The platform_driver struct isn't export and is only used for module
> init/exit functions generated by module_platform_driver() macro.
>
> Make it static to prevent namespace pollution.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603180616.TM6qYvIY-lkp@xxxxxxxxx/
> Signed-off-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

> ---
>   drivers/gpu/drm/verisilicon/vs_dc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c b/drivers/gpu/drm/verisilicon/vs_dc.c
> index 5f629d2d4beac..dad9967bc10b8 100644
> --- a/drivers/gpu/drm/verisilicon/vs_dc.c
> +++ b/drivers/gpu/drm/verisilicon/vs_dc.c
> @@ -190,7 +190,7 @@ static void vs_dc_shutdown(struct platform_device *pdev)
>   	vs_drm_shutdown_handler(dc);
>   }
>   
> -struct platform_driver vs_dc_platform_driver = {
> +static struct platform_driver vs_dc_platform_driver = {
>   	.probe = vs_dc_probe,
>   	.remove = vs_dc_remove,
>   	.shutdown = vs_dc_shutdown,

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)