Re: [PATCH] usb: typec: thunderbolt: Set enter_vdo during initialization

[Andrei Kuchynski]

On Tue, Mar 24, 2026 at 10:55 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Mar 24, 2026 at 09:02:23AM +0000, Andrei Kuchynski wrote:
> > In the current implementation, if a cable's alternate mode enter operation
> > is not supported, the tbt->plug[TYPEC_PLUG_SOP_P] pointer is cleared by the
> > time tbt_enter_mode() is called. This prevents the driver from identifying
> > the cable's VDO.
> >
> > As a result, the Thunderbolt connection falls back to the default
> > TBT_CABLE_USB3_PASSIVE speed, even if the cable supports higher speeds.
> > To ensure the correct VDO value is used during mode entry, calculate and
> > store the enter_vdo earlier during the initialization phase in tbt_ready().
> >
> > Tested-by: Madhu M <madhu.m@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Andrei Kuchynski <akuchynski@xxxxxxxxxxxx>
>
> Also a fix? In any case:
>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>

Hi Heikki,

Thank you for the review!
I'll mark this as a fix and send version 2.

Thanks,
Andrei