Re: [PATCH v2 8/9] media: i2c: ov08d10: add support for reset and power management

[Sakari Ailus]

Hi Mathias,

On Tue, Mar 24, 2026 at 09:12:40AM +0100, Matthias Fend wrote:
> > > @@ -1403,12 +1467,32 @@ static int ov08d10_probe(struct i2c_client *client)
> > >   		return ret;
> > >   	}
> > > +	ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev, NULL);
> > > +	if (IS_ERR(ov08d10->reset))
> > > +		return dev_err_probe(ov08d10->dev, PTR_ERR(ov08d10->reset),
> > > +				     "failed to get reset\n");
> > > +	reset_control_assert(ov08d10->reset);
> > > +
> > > +	for (i = 0; i < ARRAY_SIZE(ov08d10_supply_names); i++)
> > 
> > You can declare i here.
> 
> Right. But since the variable will also be needed in other places in the
> next commit, it would have to be moved again. Therefore, in the end, might
> it be simpler to leave it where it is?

Ack, sounds good.

-- 
Sakari Ailus