Re: [PATCH 1/3] dt-bindings: hwmon: Add support for NXP P3T1084UK temperature sensor

[Guenter Roeck]

On 3/23/26 09:22, Anshika Gupta wrote:
> The P3T1084UK is an NXP digital temperature sensor compatible with the
> Texas Instruments TMP108 register and protocol specification. This patch
> extends the existing DT binding for "ti,tmp108" to document the
> compatible string for P3T1084UK so that the hwmon TMP108 driver can
> bind to this device.
>
> Signed-off-by: Lakshay Piplani <lakshaypiplani77@xxxxxxxxx>
> Signed-off-by: Anshika Gupta <guptaanshika.ag@xxxxxxxxx>
> ---
>   Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> index 9f6c9f6fa561..47714df5aaff 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> @@ -4,20 +4,21 @@
>   $id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml#
>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
> -title: TMP108/P3T1035/P3T1085/P3T2030 temperature sensor
> +title: TMP108/P3T1035/P3T1084/P3T1085/P3T2030 temperature sensor
>   
>   maintainers:
>     - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>   
>   description: |
> -  The TMP108 or NXP P3T Family (P3T1035, P3T1085 and P3T2030) is a digital-
> +  The TMP108 or NXP P3T Family (P3T1035, P3T1084, P3T1085 and P3T2030) is a digital-
>     output temperature sensor with a dynamically-programmable limit window,
>     and under- and over-temperature alert functions.
>   
> -  NXP P3T Family (P3T1035, P3T1085 and P3T2030) supports I3C.
> +  NXP P3T Family (P3T1035, P3T1084, P3T1085 and P3T2030) supports I3C.
>   
>     Datasheets:
>       https://www.ti.com/product/TMP108
> +    https://www.nxp.com/docs/en/data-sheet/P3T1084UK.pdf
>       https://www.nxp.com/docs/en/data-sheet/P3T1085UK.pdf
>       https://www.nxp.com/docs/en/data-sheet/P3T1035XUK_P3T2030XUK.pdf
>   
> @@ -28,6 +29,7 @@ properties:
>             - const: nxp,p3t2030
>             - const: nxp,p3t1035
>         - const: nxp,p3t1035
> +      - const: nxp,p3t1084

Indentation seems off here.

Should nxp,p3t1084 be listed as compatible to nxp,p3t1085 instead of
requiring a code change, similar to nxp,p3t2030 and nxp,p3t1035 ?
Unless I am missing something, both use the same I3C device provisional
ID, so I assume they are register compatible.

Thanks,
Guenter

>         - const: nxp,p3t1085
>         - const: ti,tmp108
>