Re: [PATCH v1] backlight: apple_bl: Convert to a platform driver
From: Rafael J. Wysocki
Date: Tue Mar 24 2026 - 08:58:35 EST
On Mon, Mar 23, 2026 at 10:57 AM Daniel Thompson <danielt@xxxxxxxxxx> wrote:
>
> On Sat, Mar 14, 2026 at 12:50:11PM +0100, Rafael J. Wysocki wrote:
> > From: "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>
> >
> > In all cases in which a struct acpi_driver is used for binding a driver
> > to an ACPI device object, a corresponding platform device is created by
> > the ACPI core and that device is regarded as a proper representation of
> > underlying hardware. Accordingly, a struct platform_driver should be
> > used by driver code to bind to that device. There are multiple reasons
> > why drivers should not bind directly to ACPI device objects [1].
> >
> > Overall, it is better to bind drivers to platform devices than to their
> > ACPI companions, so convert the Apple Backlight ACPI driver to a
> > platform one.
> >
> > While this is not expected to alter functionality, it changes sysfs
> > layout and so it will be visible to user space.
> >
> > Link: https://lore.kernel.org/all/2396510.ElGaqSPkdT@rafael.j.wysocki/ [1]
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Reviewed-by: Daniel Thompson (RISCstar) <danielt@xxxxxxxxxx>
Thanks!
Unless anyone has any objections or concerns (in which case please let
me know), I'm going to queue up this one for 7.1.