Re: [PATCH] drm/amd/display: update outdated comments for renamed vblank_control_worker()
From: Alex Deucher
Date: Tue Mar 24 2026 - 09:25:09 EST
Applied. Thanks!
On Sat, Mar 21, 2026 at 7:14 AM Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx> wrote:
>
> The function vblank_control_worker() was renamed
> to amdgpu_dm_crtc_vblank_control_worker() by commit
> 6ce4f9ee25ff ("drm/amd/display: Add prefix to amdgpu crtc
> functions"). Update the two stale references in
> amdgpu_dm.c.
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index b3d6f2cd8ab6..c2b7b31b0d29 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -9894,7 +9894,8 @@ static void amdgpu_dm_enable_self_refresh(struct amdgpu_crtc *acrtc_attach,
> * a vblank event disable request to enable PSR/RP. PSR SU/RP
> * can be enabled immediately once OS demonstrates an
> * adequate number of fast atomic commits to notify KMD
> - * of update events. See `vblank_control_worker()`.
> + * of update events.
> + * See `amdgpu_dm_crtc_vblank_control_worker()`.
> */
> if (!vrr_active &&
> acrtc_attach->dm_irq_params.allow_sr_entry &&
> @@ -10062,8 +10063,9 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
> /*
> * If the dirty regions changed, PSR-SU need to be disabled temporarily
> * and enabled it again after dirty regions are stable to avoid video glitch.
> - * PSR-SU will be enabled in vblank_control_worker() if user pause the video
> - * during the PSR-SU was disabled.
> + * PSR-SU will be enabled in
> + * amdgpu_dm_crtc_vblank_control_worker() if user
> + * pause the video during the PSR-SU was disabled.
> */
> if (acrtc_state->stream->link->psr_settings.psr_version >= DC_PSR_VERSION_SU_1 &&
> acrtc_attach->dm_irq_params.allow_sr_entry &&
> --
> 2.25.1
>