Re: [PATCH 2/3] Input: adafruit-seesaw - add interrupt support

[Charles Dias]

On Mon, Mar 23, 2026 at 2:12 AM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> Hi Charles,
>
> On Sat, Mar 21, 2026 at 05:24:45PM -0300, charles.embedded@xxxxxxxxx wrote:
> > @@ -289,6 +341,19 @@ static int seesaw_probe(struct i2c_client *client)
> >       input_set_max_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MAX);
> >       input_set_min_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MIN);
> >
> > +     if (client->irq) {
> > +             err = seesaw_register_write_u32(client, SEESAW_GPIO_INTENSET, SEESAW_BUTTON_MASK);
> > +             if (err)
> > +                     return dev_err_probe(&client->dev, err,
> > +                                             "failed to enable hardware interrupts\n");
>
> Maybe this should be in seesaw_open()?
>
> Thanks.
>
> --
> Dmitry

Hi Dmitry. Thank you for your review!

Since this is a one-time setup, I believe it should remain as is
within the seesaw_probe() function, similar to other pin
configurations.

Please let me know if I'm missing any point here.

Best regards,
Charles Dias