Re: [PATCH v4 5/8] dt-bindings: i2c: realtek,rtl9301-i2c: extend for clocks and RTL9607C support

[Conor Dooley]

On Tue, Mar 24, 2026 at 03:30:34PM +0000, Rustam Adilov wrote:
> Hello,
> On 2026-03-23 19:41, Conor Dooley wrote:
> > On Mon, Mar 23, 2026 at 12:13:34PM +0500, Rustam Adilov wrote:
> >> Add the "realtek,rtl9607-i2c" compatible for i2c controller on the
> >> RTL9607C SoC series.
> >> 
> >> Add a clocks property to the properties to describe the i2c reference
> >> clock and make it available for all the compatibles. This i2c reference
> > 
> > Why? I can see that you're doing that, and it's good to know that that
> > is intentional, but why is it being done? Need to explain that all of
> > these devices actually do have this clock etc.
> 
> As far as available information goes, there are some datasheets that note
> the existence of these clocks. For example, RTL9310 Developer Guide 1.0 in [1]
> mentions "I2C master support 12 peripherals with 2 clocks" at page 19.

> I hope this explains the whole intention behind it. And if there is better way to explain
> this in the commit message, let me know.

What you need to say in the commit message effectively boils down to
"the existing devices have these clocks too".

Attachment: signature.asc
Description: PGP signature