Re: [PATCH v7 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens

From: Mark Brown

Date: Tue Mar 24 2026 - 14:27:30 EST


On Mon, Mar 23, 2026 at 10:38:36PM +0000, Srinivas Kandagatla wrote:
> As prepare can be called mulitple times, this can result in multiple
> graph opens for playback path.

> */
> - if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph[dai->id] == NULL) {

This is an array of APM_PORT_MAX elements but we have DAI IDs in the DT
bindings over that and now we're using the DAI ID to index into the
array (I didn't check for existing instances...). This might be
impossible due to system design though.

Attachment: signature.asc
Description: PGP signature