Re: [PATCH] pinctrl: renesas: rzg2l: Add GPIO set_config

[Geert Uytterhoeven]

On Tue, 24 Mar 2026 at 18:28, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Mon, 16 Mar 2026 at 11:19, claudiu beznea <claudiu.beznea@xxxxxxxxx> wrote:
> > On 3/13/26 15:15, Geert Uytterhoeven wrote:
> > > On Wed, 18 Feb 2026 at 16:19, Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> > >> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> > >>
> > >> Add GPIO set_config to allow setting GPIO specific functionalities.
> > >>
> > >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> > >
> > > Thanks for your patch!
> > >
> > >> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > >> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c

> This change breaks pin control and GPIO on RZ/Five:
>
>     -pinctrl-rzg2l 11030000.pinctrl: pinctrl-rzg2l support registered
>     +gpio gpiochip0: (11030000.pinctrl): setup of own GPIO can0_stb failed
>     +requesting hog GPIO can0_stb (chip 11030000.pinctrl, offset 18) failed, -95
>     +gpiochip_add_data_with_key: GPIOs 512..743 (11030000.pinctrl)
> failed to register, -95
>     +pinctrl-rzg2l 11030000.pinctrl: error -EOPNOTSUPP: failed to add
> GPIO controller
>     +pinctrl-rzg2l 11030000.pinctrl: error -EOPNOTSUPP: failed to add GPIO chip
>     +pinctrl-rzg2l 11030000.pinctrl: probe with driver pinctrl-rzg2l
> failed with error -95

And apart from also breaking mmc0 (probably due to gpio hogs not
working), it causes spurious interrupts on the Ethernet PHY:

     Microchip KSZ9131 Gigabit PHY 11c30000.ethernet-ffffffff:07:
attached PHY driver (mii_bus:phy_addr=11c30000.ethernet-ffffffff:07,
irq=38)
     [...]
    +irq 38: nobody cared (try booting with the "irqpoll" option)
    +CPU: 0 UID: 0 PID: 63 Comm: irq/38-11c30000 Not tainted
7.0.0-rc5-rzfive-07159-g46ccdb62e0e4 #488 PREEMPT
    +Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT)
    +Call Trace:
    +[<ffffffff80010c84>] dump_backtrace+0x1c/0x24
    +[<ffffffff80001226>] show_stack+0x2a/0x34
    +[<ffffffff8000c338>] dump_stack_lvl+0x32/0x4a
    +[<ffffffff8000c364>] dump_stack+0x14/0x1c
    +[<ffffffff80002588>] __report_bad_irq+0x30/0xc0
    +[<ffffffff80060034>] note_interrupt+0x12c/0x1d2
    +[<ffffffff8005dbf0>] handle_irq_event_percpu+0x30/0x3e
    +[<ffffffff8005dc36>] handle_irq_event+0x38/0x66
    +[<ffffffff80060fac>] handle_fasteoi_irq+0xa0/0xf6
    +[<ffffffff8005d574>] handle_irq_desc+0x2c/0x3a
    +[<ffffffff8005d5d4>] generic_handle_domain_irq+0x12/0x1a
    +[<ffffffff8039c61e>] plic_handle_irq+0x8a/0xb4
    +[<ffffffff8005d574>] handle_irq_desc+0x2c/0x3a
    +[<ffffffff8005d5d4>] generic_handle_domain_irq+0x12/0x1a
    +[<ffffffff80399dfe>] riscv_intc_irq+0x24/0x5c
    +[<ffffffff806bb730>] handle_riscv_irq+0x34/0x4c
    +[<ffffffff806c2bf4>] call_on_irq_stack+0x1c/0x28
    +handlers:
    +[<00000000be751d25>] irq_default_primary_handler threaded
[<000000000ed82730>] phy_interrupt
    +Disabling IRQ #38

NFS root does work.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds